refactor(plugins/kuma): refactor custom block plugins specific to Kuma #8078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartsmykla
added
the
review:tech
👷 Deploy request for kongdocs pending review.Visit the deploys page to approve it
|
Remove separate `tip.rb` and `warning.rb` plugins, which were just copies of the same code with only difference in a block name. Now the code is the same and just registered for different tags. It also correctly maps different class names between Kong and Kuma docs. Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
force-pushed
the
refactor/jekyll-kuma-custom-block-plugins
branch
from
6188e53
to
ecc57ad
Compare
|
Closing in favor of: #8082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed separate
tip.rbandwarning.rbplugins, which were just copies of the same code with only difference in a block name. Now the code is the same and just registered for different tags.It also correctly maps different class names between Kong and Kuma docs.
This is the followup on kumahq/kuma-website#2012
Testing instructions
Just go to any documentation page containing a warning or tip block to see if it renders the same as it was before
Preview link:
Checklist