feat: swaggerhub integration #8038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lena-larionova
added
do not merge
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Left a couple of comments! Let me know if you'd like another review.
Oh, I think it made sense where you put the instructions to map the SwaggerHub spec to the service, it is in a different spot than the other resources, so I think the instructions are helpful.
| 2. Select **Add API Spec**. | ||
| 3. Choose SwaggerHub as the **Source**, then pick your spec and name it. | ||
|
|
||
| Once uploaded, you can view the rendered spec on the API Specs tab in structured, YAML, or JSON format, and download it in that format. |
There was a problem hiding this comment.
Suggested change
| Once uploaded, you can view the rendered spec on the API Specs tab in structured, YAML, or JSON format, and download it in that format. | |
| Once it's uploaded, you can view the rendered spec on the API Specs tab in structured YAML or JSON format, and download it in that format. |
There was a problem hiding this comment.
"Structured" is a separate option from YAML and JSON. It's the default - it's basically the rendered UI.
lena-larionova
commented
Oct 14, 2024
Co-authored-by: Diana <[email protected]>
cloudjumpercat
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Service Catalog SwaggerHub integration doc.
I added a section on how to add/find the API specs tab to link specs to services, because it took me some poking around to find it. It's not standard for these integration pages yet, but I think it makes sense to add it here.
https://konghq.atlassian.net/browse/DOCU-4092
Testing instructions
Preview link:
https://deploy-preview-8038--kongdocs.netlify.app/konnect/service-catalog/integrations/
https://deploy-preview-8038--kongdocs.netlify.app/konnect/service-catalog/integrations/swaggerhub/
Checklist