Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version variable on old mesh docker installs #8013

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Oct 2, 2024

Description

Fixed the version variable on the Docker Mesh install docs to stop pointing to latest and point to current page version instead. Pulled the resulting docker images with no issue.

Checked the rest of the Mesh install docs, this issue only happens on Docker.

Fixes #4991.

Testing instructions

Preview link: https://deploy-preview-8013--kongdocs.netlify.app/mesh/2.1.x/installation/docker/

Checklist

@lena-larionova lena-larionova added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Oct 2, 2024
@lena-larionova lena-larionova requested a review from a team as a code owner October 2, 2024 23:49
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 822c31a
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66fddc18bf5d30000818d892
😎 Deploy Preview https://deploy-preview-8013--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (no change from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Guaris Guaris merged commit d98a3ff into main Oct 3, 2024
21 checks passed
@Guaris Guaris deleted the fix/issue-4991 branch October 3, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kong Mesh doc for Docker install on older versions shows latest version only
3 participants