Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug bash: Wrong statement about cache hit meaning #8004

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Bug bash: Wrong statement about cache hit meaning #8004

merged 2 commits into from
Oct 2, 2024

Conversation

Guaris
Copy link
Contributor

@Guaris Guaris commented Oct 2, 2024

@Guaris Guaris added review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? skip-changelog labels Oct 2, 2024
@Guaris Guaris requested a review from a team as a code owner October 2, 2024 19:36
@netlify Netlify
Copy link

netlify bot commented Oct 2, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit d9324b4
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66fdba8ff9034d0009963349
😎 Deploy Preview https://deploy-preview-8004--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 93 (no change from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

lena-larionova
lena-larionova approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit for typo, otherwise lgtm

app/_src/gateway/get-started/proxy-caching.md Outdated Show resolved Hide resolved
@Guaris Guaris merged commit 3ca4279 into main Oct 2, 2024
5 checks passed
@Guaris Guaris deleted the issue-5262 branch October 2, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lena-larionova lena-larionova lena-larionova approved these changes

Assignees
No one assigned
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guaris @lena-larionova