Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add context plumbing and enforce errcheck via golangci-lint config #1509

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jan 28, 2025

No description provided.

@pmalek pmalek self-assigned this Jan 28, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.16%. Comparing base (b786101) to head (ec59dad).

Files with missing lines Patch % Lines
tests/integration/test_utils.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage   29.16%   29.16%           
=======================================
  Files          62       62           
  Lines        6666     6666           
=======================================
  Hits         1944     1944           
  Misses       4583     4583           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek marked this pull request as ready for review January 28, 2025 10:27
@pmalek pmalek mentioned this pull request Jan 28, 2025
- dogsled
- durationcheck
- errcheck
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is net new.

@mheap mheap merged commit 44b5f64 into main Jan 28, 2025
23 checks passed
@mheap mheap deleted the context-plumbing-golangci-lint-config branch January 28, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants