Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump go-database-reconciler to 1.18.1 #1500

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

harshadixit12
Copy link
Contributor

chore(deps): Bump go-database-reconciler to 1.18.1

This fixes #1488
PR on go-database-reconciler for reference: Kong/go-database-reconciler#165

Some indirect dependencies have been bumped as well.

Changelog: https://github.com/Kong/go-database-reconciler/releases/tag/v1.18.1

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.16%. Comparing base (e44874a) to head (03bb323).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
- Coverage   29.22%   29.16%   -0.06%     
==========================================
  Files          62       62              
  Lines        6666     6666              
==========================================
- Hits         1948     1944       -4     
- Misses       4580     4583       +3     
- Partials      138      139       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Prashansa-K
Copy link
Contributor

@harshadixit12 Could you please fix the failing tests? The new gdr version had the select-tags fix. So, those tests may be failing. Refer to my GDR PR to see the test fix.

@harshadixit12 harshadixit12 force-pushed the chore/bump-go-database-reconciler-to-1.18.1 branch 2 times, most recently from fd89f20 to 25eae2e Compare January 23, 2025 10:00
@harshadixit12 harshadixit12 force-pushed the chore/bump-go-database-reconciler-to-1.18.1 branch from 25eae2e to 03bb323 Compare January 23, 2025 10:14
@Prashansa-K Prashansa-K merged commit 310f0f2 into main Jan 23, 2025
21 checks passed
@Prashansa-K Prashansa-K deleted the chore/bump-go-database-reconciler-to-1.18.1 branch January 23, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Konnect URL is invalid when passing --konnect-addr that doesn't contain api.konghq
3 participants