fix: fixing consumer-group related dump config for deck. #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
With changes added in go-kong, to skip listing consumers while doing a GET call on a consumer_group, dump config with gw 3.9+ starting showing issues. Associations between a consumer and consumer-group were missing. Thus, we are pushing the no listing consumers feature behind a flag for now, applicable only for dump command as a starting point.
These new versions have the necessary changes to not list consumers during a deck dump while using the necessary flag
Prashansa-K
force-pushed
the
fix/dump-cg-groups-association
branch
from
66112e0 to
358eab4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1486 +/- ##
==========================================
+ Coverage 29.55% 29.59% +0.03%
==========================================
Files 61 61
Lines 6577 6583 +6
==========================================
+ Hits 1944 1948 +4
- Misses 4494 4497 +3
+ Partials 139 138 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With changes added in go-kong, to skip
listing consumers while doing a GET call
on a consumer_group, dump config with gw
3.9+ starting showing issues. Associations
between a consumer and consumer-group were
missing. Thus, we are pushing the no listing
consumers feature behind a flag for now,
applicable only for dump command as a
starting point.
Changes for sync/diff command would be added
in a separate PR.
Requires the following to be merged first:
Kong/go-database-reconciler#159
Kong/go-kong#494