Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): add lock_dictionary_name to expected Konnect state #1449

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

nowNick
Copy link
Contributor

@nowNick nowNick commented Nov 22, 2024

With the introduction of a new field lock_dictionary_name in RLA plugin the tests in Konnect started to fail:
https://github.com/Kong/deck/actions/runs/11952452461/job/33375633872?pr=1439

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.55%. Comparing base (38e6449) to head (70d90bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1449   +/-   ##
=======================================
  Coverage   27.55%   27.55%           
=======================================
  Files          61       61           
  Lines        6294     6294           
=======================================
  Hits         1734     1734           
  Misses       4432     4432           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nowNick nowNick self-assigned this Nov 22, 2024
@nowNick nowNick force-pushed the tests/fix-kong-locks-test-issue branch from f4d328f to 70d90bc Compare November 22, 2024 14:22
@nowNick nowNick marked this pull request as ready for review November 22, 2024 14:29
@Prashansa-K Prashansa-K merged commit 5cdea5d into main Nov 22, 2024
19 checks passed
@Prashansa-K Prashansa-K deleted the tests/fix-kong-locks-test-issue branch November 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants