Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test global config with info share tag #1091

Merged
merged 13 commits into from
Nov 9, 2023

Conversation

AntoineJac
Copy link
Collaborator

No description provided.

@AntoineJac AntoineJac requested a review from a team November 8, 2023 11:09
@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (d110df8) 32.87% compared to head (1defd73) 32.79%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   32.87%   32.79%   -0.09%     
==========================================
  Files         103      103              
  Lines       12847    12898      +51     
==========================================
+ Hits         4224     4230       +6     
- Misses       8214     8257      +43     
- Partials      409      411       +2     
Files Coverage Δ
file/types.go 56.13% <ø> (ø)
file/reader.go 59.49% <0.00%> (-2.35%) ⬇️
file/builder.go 47.46% <63.63%> (+0.12%) ⬆️
cmd/common.go 3.72% <11.53%> (-0.23%) ⬇️
dump/dump.go 1.39% <0.00%> (-0.06%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntoineJac AntoineJac changed the base branch from main to feat/add-look-up-tags November 9, 2023 07:22
@AntoineJac AntoineJac merged commit 1680dfb into Kong:feat/add-look-up-tags Nov 9, 2023
17 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants