Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct bug with Konnect multi-region login #1089

Merged
merged 1 commit into from
Nov 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Table of Contents

- [v1.29.1](#v1291)
- [v1.29.0](#v1290)
- [v1.28.1](#v1281)
- [v1.28.0](#v1280)
Expand Down Expand Up @@ -69,6 +70,14 @@
- [v0.2.0](#v020)
- [v0.1.0](#v010)

## [v1.29.1]

> Release date: 2023/11/07
### Fixes

- Correct a bug preventing logins with Konnect in the EU region.
[#1089](https://github.com/Kong/deck/pull/1089)

## [v1.29.0]

Expand Down Expand Up @@ -105,12 +114,12 @@
compatibility, but in the future that will be removed. Please update to the new structure
(see 'changes')._

> __IMPORTANT__: _The recently added decK command `deck file openapi2kong` implemented different techniques for
generating decK configuration from OpenAPI spec files then the legacy `inso` tool. In particular, entity names and identifiers
> __IMPORTANT__: _The recently added decK command `deck file openapi2kong` implemented different techniques for
generating decK configuration from OpenAPI spec files then the legacy `inso` tool. In particular, entity names and identifiers
were generated differently in the more recent implementation. For existing `inso` users, this may cause issues with migrating
to the new tool as names and IDs are used by Kong Gateway to identify entities. In response we have added a
to the new tool as names and IDs are used by Kong Gateway to identify entities. In response we have added a
`--inso-compatible` flag to the `deck file openapi2kong` command to support a smoother migration for these users. For more
information on this and other APIOps commands, see the
information on this and other APIOps commands, see the
[go-apiops documentation page](https://github.com/Kong/go-apiops/tree/main/docs).

### Added
Expand All @@ -133,15 +142,15 @@ information on this and other APIOps commands, see the
[#1051](https://github.com/Kong/deck/pull/1051)
- The top-level CLI commands have been restructured. All commands now live under 2
subcommands (`gateway` and `file`) to clarify their use and (in the future) reduce the clutter of
the many global flags only relevant to a few commands.
the many global flags only relevant to a few commands.
Using the old commands will still work but
will print a deprecation notice. Please update your usage to the new commands.
The new commands are more unix-like;

- default to `stdin`/`stdout` and no longer to "`kong.yaml`"
- the `-s` / `--state` flag is gone, files can be listed without the flag
- the `--online` flag for `validate` is gone; use `gateway validate` for online, `file validate` for local.

PR [#962](https://github.com/Kong/deck/pull/962)

## [v1.27.1]
Expand Down Expand Up @@ -1464,6 +1473,7 @@ No breaking changes have been introduced in this release.

Debut release of decK

[v1.29.1]: https://github.com/kong/deck/compare/v1.29.0...v1.29.1
[v1.29.0]: https://github.com/kong/deck/compare/v1.28.1...v1.29.0
[v1.28.1]: https://github.com/kong/deck/compare/v1.28.0...v1.28.1
[v1.28.0]: https://github.com/kong/deck/compare/v1.27.1...v1.28.0
Expand Down
2 changes: 1 addition & 1 deletion konnect/login_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func (s *AuthService) OrgUserInfo(ctx context.Context) (*OrgUserInfo, error) {
// replace geo-specific endpoint with global one for retrieving org info
client := *s.client
client.baseURL = strings.Replace(s.client.baseURL, "eu.", "global.", 1)
client.baseURL = strings.Replace(s.client.baseURL, "au.", "global.", 1)
client.baseURL = strings.Replace(client.baseURL, "au.", "global.", 1)

req, err := client.NewRequest(http.MethodGet, "/v2/organizations/me", nil, nil)
if err != nil {
Expand Down