Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): validate was setting wrong filenames #1084

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Nov 3, 2023

No description provided.

@Tieske Tieske marked this pull request as ready for review November 3, 2023 16:18
@Tieske Tieske requested a review from a team November 3, 2023 16:18
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Rick Spurgeon <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (8ce58a6) 32.87% compared to head (d4dea85) 32.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
- Coverage   32.87%   32.87%   -0.01%     
==========================================
  Files         103      103              
  Lines       12848    12850       +2     
==========================================
  Hits         4224     4224              
- Misses       8215     8217       +2     
  Partials      409      409              
Files Coverage Δ
cmd/gateway_validate.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aboudreault aboudreault merged commit b3ccdd5 into main Nov 3, 2023
33 of 34 checks passed
@aboudreault aboudreault deleted the fix/validate branch November 3, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants