added support for custom kernel function names #320
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a response to Issue #251 , this PR aims to add support for custom function names (with which it becomes possible to use .spv shaders generated from openCL source files with the
clspv
tool). The only modification is to use a new fieldmKernelFunctionName
instead of the hard-coded"main"
constant that can be fed to the constructor of theAlgorithm
class as well as to thealgorithm
method of theManager
class. This parameter is added as the last one, with a default value of"main"
so it should be completely backwards compatible. (As for openCL sources, it is forbidden to usemain
as the name of a kernel function, using suchspv
files without adding an explicitasm("main")
suffix in the shader it was impossible, which is doable only if there is only one declared kernel function in thecl
file so asm-hacking the name of the kernel function is not a complete solution.)