Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for custom kernel function names #320

Closed
wants to merge 1 commit into from
Closed

added support for custom kernel function names #320

wants to merge 1 commit into from

Conversation

szabivan
Copy link

In a response to Issue #251 , this PR aims to add support for custom function names (with which it becomes possible to use .spv shaders generated from openCL source files with the clspv tool). The only modification is to use a new field mKernelFunctionName instead of the hard-coded "main" constant that can be fed to the constructor of the Algorithm class as well as to the algorithm method of the Manager class. This parameter is added as the last one, with a default value of "main" so it should be completely backwards compatible. (As for openCL sources, it is forbidden to use main as the name of a kernel function, using such spv files without adding an explicit asm("main") suffix in the shader it was impossible, which is doable only if there is only one declared kernel function in the cl file so asm-hacking the name of the kernel function is not a complete solution.)

@szabivan szabivan closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant