-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candidate #3
base: main
Are you sure you want to change the base?
Conversation
… loop/iter handling
Grabbed task 5: Wrap all relevant unit tests with cross_target_tests example |
Grabbed task 3: Generic error handling in the dispatcher. Current error handling still has remnants of now refactored dispatcher. ref |
Grabbed task 6: Migrate docker test framework from Komodo DeFi Framework into Sia Rust. There are tests throughout the codebase that rely on a hardcoded URL to a walletd index node. Remove these in favor of mocked API or walletd docker containers. |
To do:
incorporate and security review types: Switch to fixed-length PolicyHash preimage SiaFoundation/core#207 ref
implement methods in V2TransactionBuilder for atomic swap signing. Requires
impl SatisfyPolicy for AtomicSwap
refGeneric error handling in the dispatcher. Current error handling still has remnants of now refactored dispatcher. ref
Move the example client to a rust doc example
Wrap all relevant unit tests with
cross_target_tests
exampleMigrate docker test framework from Komodo DeFi Framework into Sia Rust. There are tests throughout the codebase that rely on a hardcoded URL to a walletd index node. Remove these in favor of mocked API or walletd docker containers.
Implement the remaining file contract related types for V2Transaction. This is not critical for final delivery as we can safely ignore this data in deserialization and will never do serialization. At a minimum, replace
todo!()
s with error handling or empty data. ref1 ref2