-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From Ewelink : Add Dooya Curtain,Reax Curtain and AK Curtain. #8510
base: master
Are you sure you want to change the base?
From Ewelink : Add Dooya Curtain,Reax Curtain and AK Curtain. #8510
Conversation
src/lib/ewelink.ts
Outdated
@@ -31,6 +722,108 @@ export const ewelinkModernExtend = { | |||
voltageReportingConfig: {min: 3600, max: 7200, change: 10}, | |||
}); | |||
}, | |||
ewelinkWindowCovering(args: WindowCoveringArgs): ModernExtend { | |||
args = {stateSource: 'lift', configureReporting: true, ...args}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you call the windowCovering
modernExtend here and extend based on that instead of duplicating all the code?
src/lib/ewelink.ts
Outdated
const ea = access; | ||
|
||
// ====================== Type Or Interface ============================== | ||
interface WindowCoveringArgs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extend the existing WindowCoveringArgs
src/lib/ewelink.ts
Outdated
|
||
// ======================= Custom FZ ===================================== | ||
export const ewelinkFromZigbee = { | ||
cover_position_tilt: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also prevent code duplication here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review. We will modify the code, complete the testing, and resubmit it
Hello, I have reused the windowCovering modernExtend as per your request. Please review it again. |
Hello, I am an employee at EweiLink. This is my first time submitting a PR for ZHC, and the purpose is to familiarize myself with the entire PR process for smoother collaboration in the future. If the PR is successfully approved, I will synchronize all devices currently supported by the two manufacturers, Ewelink and Sonoff, to ZHC!!
features:
All the above features are successfully running on our gateway based on Z2M!!