Adding support for Tuya TS0225 Human presence sensor #8490
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that illuminance_lux() was removed with #8304 but I'm not sure about the additional datapoints, how is this usually done? Does it need to be added in ../lib/tuya.ts (This is my first PR here, I don't understand most of the code at his point). |
Koenkk
reviewed
Dec 21, 2024
| [103, 'departure_delay', tuya.valueConverter.raw], | ||
| [104, 'entry_filter_time', tuya.valueConverter.divideBy100], | ||
| [105, 'block_time', tuya.valueConverter.divideBy10], | ||
| [107, 'illuminance_lux', tuya.valueConverter.divideBy10], |
There was a problem hiding this comment.
Suggested change
| [107, 'illuminance_lux', tuya.valueConverter.divideBy10], | |
| [107, 'illuminance', tuya.valueConverter.divideBy10], |
And use e.illuminance() instead.
Koenkk
reviewed
Dec 21, 2024
| ], | ||
| description: 'Human presence sensor', | ||
| fromZigbee: [tuya.fz.datapoints, fz.ias_occupancy_alarm_1, fz.ias_occupancy_alarm_1_report], | ||
| toZigbee: [tuya.tz.datapoints, tzDatapoints], |
There was a problem hiding this comment.
Suggested change
| toZigbee: [tuya.tz.datapoints, tzDatapoints], | |
| toZigbee: [tuya.tz.datapoints], |
Koenkk
reviewed
Dec 21, 2024
| model: 'MTD085-ZB', | ||
| vendor: 'LeapMMW', | ||
| whiteLabel: [ | ||
| tuya.whitelabel('LeapMMW', 'MTD095-ZB', 'Human presence sensor', ['_TZ321C_4slreunp']), |
There was a problem hiding this comment.
This can be removed (same as model and vendor)
|
Could you also submit a picture for the docs? This can be done by:
Make sure that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just used the online editor, I hope I got everything right as I wouldn't know how to test this locally.
resolves #23913