-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: speed-controlled fans #8188
base: master
Are you sure you want to change the base?
Conversation
This implements converters for speed-controlled fans. These fans are implemented as level-controlled devices on the ZigBee side (having a onOff and levelCtrl cluster), thus no speed translation is necessary and their state can be handled by the normal on_off converters.
This is a custom self-built device for ventilating spaces. It contains a valve and a speed-controlled fan, the valve is automatically opened when the fan runs. The Zigbee standard fan cluster is unsuitable for this type of device, so instead a level-controlled device type is used, allowing for fine speed control over the fan. I'll publish the design files and firmware for this eventually, but we need one device to test the speed-controlled fan device model in Z2M so we need it in there already.
zigbeeModel: ['FanBee1', 'Fanbox2'], | ||
model: 'FanBee', | ||
vendor: 'Lorenz Brun', | ||
description: 'Fan with valve', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a link to this device? Note to self; after this merge Koenkk/zigbee2mqtt#24483
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a custom device built by me. I'll eventually open-source the design files and firmware, but right now there is no public docs or anything for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those type of devices, you can use the external converters (there is no point of adding it to the list of officially supported devices if nobody can get it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but for the tests we need a device which exercises this behavior. There is an Inovelli fan which looks like it could also use this fan control model but as I do not own one of them I didn't feel comfortable changing it over to the new model (also this is a breaking change for anyone using the MQTT API).
I do intend on making this device publicly available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do intend on making this device publicly available.
Good, then I will merge it once this is done.
This implements converters for speed-controlled fans. These fans are
implemented as level-controlled devices on the ZigBee side (having a
onOff and levelCtrl cluster), thus no speed translation is necessary and
their state can be handled by the normal on_off converters.
Also adds my custom FanBee device as we need one device to run tests
against.
Co-dependent with Koenkk/zigbee2mqtt#24483