-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update candeo.ts #8147
base: master
Are you sure you want to change the base?
Update candeo.ts #8147
Conversation
Adding Candeo C-ZB-SM205-2G
@Koenkk Can you please help with this lint formatting error again please? Still can't see what we're getting wrong here... |
src/devices/candeo.ts
Outdated
await reporting.bind(endpoint2, coordinatorEndpoint, ['genOnOff']); | ||
await reporting.onOff(endpoint1); | ||
await reporting.onOff(endpoint2); | ||
await endpoint1.read('genOnOff', [0x0000]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these reads needed?
Hi @Koenkk - to give the user a better out-of-the-box experience, and ensuring that the states of the device are accurately presented straight away. |
But how are these values exposes? Because I see no corresponding expose and fromZigbee converter. |
Sorry, we're not really sure what specifically you're asking. Can you please give us more info if there's a better way to do this, or if we've added something that looks incorrect to you? |
I cleaned the code a bit, can you check if everything is still OK? |
Thanks for taking a look at this. A problem we have is that a converter using modern extend does not offer powerOnBehaviour correctly for multi endpoint devices. Initial view of your changes - it looks like -
|
|
Would it be possible to go with the code we have written? We have tested this and we are happy that it works with our device, providing the features that the device supports. If the updates to modernExtend in the next rollout fix issues 1 and 2 on this list, we will edit the code to use modernExtend instead. Thanks |
|
Thanks. We don't have a dev branch setup, so can't test your responses to 1, 2, 3 of our observations.
As per my previous message, is there a good reason that we cannot go ahead with our tested and working code? And then we can modify the code once we've tested on the 1 November release. |
Switching to the dev branch is documented here: https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html, does that help?
If the value doesn't change, why do you want to have it reported again? |
Thanks. I understand, but 18 hours is a long time, and we would prefer a more regular reporting. I am not able to switch to dev branch on my current set up. I go back to my earlier question - is there a good reason that we cannot go ahead with our tested and working code? Is it simply because you want more slimline code? We will slim it down after the November release if everything works as you're saying... Is that ok? |
Ok then let's do that! Could you update the PR again? |
Thank you for this. We will be sure to look at again after the next roll out. Sorry - I don't think I've done this correctly. Please forgive the newbie approach to Github. |
Adding Candeo C-ZB-SM205-2G