forked from sheaivey/rx5808-pro-diversity
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and updates #1
Open
bluesign2k
wants to merge
7
commits into
Knifa:tidy-up
Choose a base branch
from
bluesign2k:tidy-up
base: tidy-up
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jan 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 6488c7e - Browse repository at this point
Copy the full SHA 6488c7eView commit details -
Using INPUT_PULLUP as an argument for digitalWrite is risky at best as a method to enable the pullup on a pin (valid parameters are 0 (LOW) or 1 (HIGH). INPUT_PULLUP has a value of 2). Setting pullups should be done thorugh pinMode. See here: https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/cores/arduino/Arduino.h https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/cores/arduino/wiring_digital.c
Configuration menu - View commit details
-
Copy full SHA for b1abbf1 - Browse repository at this point
Copy the full SHA b1abbf1View commit details
Commits on Jan 22, 2017
-
Replaced the low level SPI driver for a more generic RX5808 one. This should allow for more flexible control of receivers and later addition of new features, including individual control of receivers, setting arbitrary frequencies, and generally improving code structure.
Configuration menu - View commit details
-
Copy full SHA for 4a0ad65 - Browse repository at this point
Copy the full SHA 4a0ad65View commit details -
Merge remote-tracking branch 'refs/remotes/origin/new-receiver-librar…
…y' into Knifa/tidy-up
Configuration menu - View commit details
-
Copy full SHA for db8ac28 - Browse repository at this point
Copy the full SHA db8ac28View commit details
Commits on Jan 30, 2017
-
As requested, replaced tabs with spaces and lowercase function names
Configuration menu - View commit details
-
Copy full SHA for 7879b94 - Browse repository at this point
Copy the full SHA 7879b94View commit details
Commits on Jan 31, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d045aaa - Browse repository at this point
Copy the full SHA d045aaaView commit details
Commits on Aug 25, 2017
-
Configuration menu - View commit details
-
Copy full SHA for dac5b05 - Browse repository at this point
Copy the full SHA dac5b05View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.