Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe_as_z_home: Initial implementation and documentation #6774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickweedon
Copy link

This pull request adds the ability to perform multiple probes when issuing a G28 command. More specifically it calls into the 'probe' logic to execute a probe in a way similar to what would be performed during bed mesh creation. Since it uses the same logic this means that the resulting probe also applies the same calc_probe_z_average method to the result.

The benefit of this feature is it allows users with less than perfect probing hardware to still have an unsupervised and reliable homing experience which is crucial to ensure print quality and preventing failed prints due to an incorrect Z homing. Bad homing can even lead to extruder jams and waste significant amounts of the 3D printer user's time. This is a feature that has been requested many times with one such example being Discourse: multiple-samples-on-home-z.

To configure this tool a new configuration section called [probe_as_z_home] should be placed anywhere in the config before the either [safe_z_homing] or [homing_override].

The implementation is completely decoupled from any particular homing or probing method and does not modify any existing code.

@nickweedon nickweedon force-pushed the master branch 3 times, most recently from cdbf5b6 to 69ebeba Compare January 1, 2025 18:33
* Added tool 'probe_as_z_home' that allows probing to be used for Z homing when a empty [probe_as_z_home]
  section is added to the configuration.
* Added relevant documentation to 'Config_Reference.md'.

Signed-off-by: Nick Weedon <[email protected]>
@nickweedon nickweedon force-pushed the master branch 2 times, most recently from e9ad6f0 to 1328faf Compare January 4, 2025 19:14
@vgdh
Copy link

vgdh commented Jan 12, 2025

great!

Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants