-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: python 3.12 support #6773
base: master
Are you sure you want to change the base?
Conversation
Import test succeeds, runs on a multi-mcu test box with kinematics: None |
Signed-off-by: Aaron Haun <[email protected]>
Regression tests pass on py3.12, with fresh dicts built on buster. |
BTW:
But of course, the correct versions are better, |
Thanks for looking at this. In general it seems fine. I'd just like to confirm that we do need to pin these versions and that there isn't some version of setuptools and python-can that works with a wide variety of python versions? Cheers, |
Setuptools isn't needed at all on older versions, it provides a backfill for distutils, which has been removed. |
Okay, thanks. So we have to specify two different versions for python-can (one for <3.12 and one for >3.12). I didn't understand your answer about setuptools though - there is not a version of setuptools we can reasonably use across all python versions? (It's fine if the answer is yes - I just want to be sure I understand the change.) Cheers, |
It's more that we don't need setuptools in prior versions, because the functionality that it is adding was part of the standard distribution. https://peps.python.org/pep-0632/ Setuptools contains compatibility shims that allows the use of the distutils package and modules. |
I think it'd be preferable to have every instance be pinned to a single version of setuptools, even if not all instances need it. It's just easier for debugging and troubleshooting if all instances are running as much of the same code as possible. I understand if we can't pin a single version though - so that's my main question - do you know if we can pin a single version of setuptools? Thanks again, |
AFAIK the requirement is either to upgrade |
Entirely just some adjustments to dependencies.
Based on initial analysis by Sineos over at the discourse: https://klipper.discourse.group/t/discuss-python-versions/20942/10