-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support white neopixel strings #6758
base: master
Are you sure you want to change the base?
Conversation
@@ -34,7 +34,7 @@ def __init__(self, config): | |||
raise config.error("color_order does not match chain_count") | |||
color_indexes = [] | |||
for lidx, co in enumerate(color_order): | |||
if sorted(co) not in (sorted("RGB"), sorted("RGBW")): | |||
if any(c not in "RGBW" for c in co): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This validation is insufficient, it allows strings like RRRRR
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was certain that I saw other single color cob strips on aliexpress, but I can't seem to find them now :-)
What do you think the best approach here would be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you're bringing up single colors. The best approach would be to perform sufficient validation so that strings like RRRRRRRRRRRRRRRRRRGBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB
aren't accepted.
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Support white neopixel strings
This change allows white single color neopixel cob strips to work like this one https://vi.aliexpress.com/item/1005005946691268.html?spm=a2g0o.order_list.order_list_main.10.57261802SVIh97&gatewayAdapt=glo2vnm
Tested it on my setup, and it works as expected.
I have updated the relevant documentation.
The new check allows you also to enter color_order of one or two characters. This allows to enter just W and then have all the white subparts adresable on their own.
Signed-off-by: Lovro Oreskovic [email protected]