Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Clear CMAKE_INSTALL_NAME_TOOL to fix packaging of VTK modules on macOS #164

Merged
merged 1 commit into from
Jan 12, 2024
Merged

COMP: Clear CMAKE_INSTALL_NAME_TOOL to fix packaging of VTK modules on macOS #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions SuperBuild/External_vtkRenderingOpenVR.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ if(NOT DEFINED ${proj}_DIR AND NOT ${SUPERBUILD_TOPLEVEL_PROJECT}_USE_SYSTEM_${p
)
endif()

if(APPLE)
# Clearing CMAKE_INSTALL_NAME_TOOL is crucial to ensure that the installed
# VTK libraries have their ID associated with a full path. This step is
# required for the fix-up process to work as expected.
list(APPEND EXTERNAL_PROJECT_OPTIONAL_CMAKE_CACHE_ARGS
-DCMAKE_INSTALL_NAME_TOOL:FILEPATH=
)
endif()

if(NOT EXISTS ${VTKExternalModule_SOURCE_DIR})
message(FATAL_ERROR "VTKExternalModule_SOURCE_DIR [${VTKExternalModule_SOURCE_DIR}] variable is set to a nonexistent directory")
endif()
Expand Down
9 changes: 9 additions & 0 deletions SuperBuild/External_vtkRenderingOpenXR.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ if(NOT DEFINED ${proj}_DIR AND NOT ${SUPERBUILD_TOPLEVEL_PROJECT}_USE_SYSTEM_${p
)
endif()

if(APPLE)
# Clearing CMAKE_INSTALL_NAME_TOOL is crucial to ensure that the installed
# VTK libraries have their ID associated with a full path. This step is
# required for the fix-up process to work as expected.
list(APPEND EXTERNAL_PROJECT_OPTIONAL_CMAKE_CACHE_ARGS
-DCMAKE_INSTALL_NAME_TOOL:FILEPATH=
)
endif()

if(NOT EXISTS ${VTKExternalModule_SOURCE_DIR})
message(FATAL_ERROR "VTKExternalModule_SOURCE_DIR [${VTKExternalModule_SOURCE_DIR}] variable is set to a nonexistent directory")
endif()
Expand Down
9 changes: 9 additions & 0 deletions SuperBuild/External_vtkRenderingOpenXRRemoting.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ if(NOT DEFINED ${proj}_DIR AND NOT ${SUPERBUILD_TOPLEVEL_PROJECT}_USE_SYSTEM_${p
)
endif()

if(APPLE)
# Clearing CMAKE_INSTALL_NAME_TOOL is crucial to ensure that the installed
# VTK libraries have their ID associated with a full path. This step is
# required for the fix-up process to work as expected.
list(APPEND EXTERNAL_PROJECT_OPTIONAL_CMAKE_CACHE_ARGS
-DCMAKE_INSTALL_NAME_TOOL:FILEPATH=
)
endif()

if(NOT EXISTS ${VTKExternalModule_SOURCE_DIR})
message(FATAL_ERROR "VTKExternalModule_SOURCE_DIR [${VTKExternalModule_SOURCE_DIR}] variable is set to a nonexistent directory")
endif()
Expand Down
9 changes: 9 additions & 0 deletions SuperBuild/External_vtkRenderingVR.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ if(NOT DEFINED ${proj}_DIR AND NOT ${SUPERBUILD_TOPLEVEL_PROJECT}_USE_SYSTEM_${p
)
endif()

if(APPLE)
# Clearing CMAKE_INSTALL_NAME_TOOL is crucial to ensure that the installed
# VTK libraries have their ID associated with a full path. This step is
# required for the fix-up process to work as expected.
list(APPEND EXTERNAL_PROJECT_OPTIONAL_CMAKE_CACHE_ARGS
-DCMAKE_INSTALL_NAME_TOOL:FILEPATH=
)
endif()

if(NOT EXISTS ${VTKExternalModule_SOURCE_DIR})
message(FATAL_ERROR "VTKExternalModule_SOURCE_DIR [${VTKExternalModule_SOURCE_DIR}] variable is set to a nonexistent directory")
endif()
Expand Down