Simplify interactor style leveraging base class implementation #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for the removal of duplicated functions in a subsequent commit, this update explicitly copies over the duplicated content to clarify the scope of the forthcoming changes. Additionally, it eliminates the now-obsolete `StartDolly3D` and `EndDolly3D` functions. These functions became outdated with the refactoring in Kitware/VTK@7a2c71e48a (VRInteractorStyle code refactoring), where they were replaced by `Movement3D`, `StartMovement3D`, and `EndMovement3D`. The `Movement3D` function now invokes `Dolly3D` when the current state is configured as `VTKIS_DOLLY`. Furthermore, this commit removes the use of the `GetMappedAction` function from `OnSelect3D()`. Since the "controller action" (e.g., `vtkEventDataAction::Press`) can be obtained directly from the event, the base class implementation suffices. This allows the retrieval of the "mapper action" from the `InputMap` without using `GetMappedAction`.
Removes functions `OnSelect3D`, `OnMove3D`, `OnViewerMovement3D`, `StartAction`, `EndAction`, `Movement3D` and `SetInteractor` functions that are available in the base class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes functions
OnSelect3D,OnMove3D,OnViewerMovement3D,StartAction,EndAction,Movement3DandSetInteractorfunctions that are availablein the base class.
Related to: