Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Always discard display position for 3D Event #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Dec 21, 2023

Adapted from Slicer/Slicer@a0ad2a328 (ENH: Handle 3D events in MRML interactor style and markups VTK widgets)

Adapted from Slicer/Slicer@a0ad2a328 (ENH: Handle 3D events in MRML
interactor style and markups VTK widgets)
@@ -219,6 +219,9 @@ bool vtkVirtualRealityViewInteractorObserver::DelegateInteractionEventDataToDisp
ed->SetAccuratePicker(vrViewInteractorStyle->GetAccuratePicker());
}

// Assumes event are all 3D and invalidates display position
ed->SetDisplayPositionInvalid();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not have to do this. Based on our discussion, it looks like this is native to Slicer's bookkeeping of whether to compute the world position again. See https://github.com/Slicer/Slicer/blob/4ed0396cf865870dffe887e28db588434ce23b02/Libs/MRML/DisplayableManager/vtkMRMLInteractionEventData.cxx#L356C79-L358

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All events have 3D and display position, too. Display position may be less useful in virtual reality (e.g., a Google-glass-like 2D overlay), but we may use it in the future. The flags for valid "accurate" and "display" positions are indeed for avoiding (potentially costly) recomputations. The same event is given to many displayable managers, so we can save time by computing it only once and storing the result.

Copy link
Contributor Author

@jcfr jcfr Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we may use it in the future

That is sensible.

Should we simply remove this method then ?

For reference, it was originally introduced here:

Slicer/Slicer@a0ad2a3#diff-3c145879816516bad207b32924f5bb882c68f6c0de514970fca6f372eee76b86R290-R295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants