Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(translator): template patching via translator #16

Merged
merged 5 commits into from
Dec 8, 2023
Merged

feat(translator): template patching via translator #16

merged 5 commits into from
Dec 8, 2023

Conversation

jourdain
Copy link
Collaborator

No description provided.

@jourdain jourdain mentioned this pull request Nov 21, 2023
Merged
alesgenova
alesgenova approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@alesgenova alesgenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good.
I have improved the tests and examples to also cover the case in which we have nested apps

@jourdain jourdain merged commit 0e854ac into master Dec 8, 2023
4 checks passed
@jourdain jourdain deleted the add-translator-support branch December 8, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alesgenova alesgenova alesgenova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jourdain @alesgenova