fix(translation): auto translate state names in event too

Kitware · Sep 20, 2024 · 46a2c74 · 46a2c74
1 parent f0584c1
commit 46a2c74
Showing 1 changed file with 20 additions and 4 deletions.
diff --git a/trame_client/widgets/core.py b/trame_client/widgets/core.py
@@ -469,7 +469,7 @@ def attrs(self, *names):
                     else:
                         translated_value = str(value[0])
                         if AbstractElement._debug:
-                            logger.warn(
+                            logger.warning(
                                 'Warning: <%s %s="..." /> is set with an (%s)',
                                 self._elem_name,
                                 js_key,
@@ -531,7 +531,12 @@ def events(self, *names):
                     continue
 
                 if isinstance(value, str):
-                    self._attributes[name] = f'{js_key}="{value}"'
+                    translated_value = (
+                        self.server.state.translator.translate_js_expression(
+                            self.server.state, value
+                        )
+                    )
+                    self._attributes[name] = f'{js_key}="{translated_value}"'
                 elif callable(value):
                     trigger_name = self.server.trigger_name(value)
                     self._attributes[name] = f"{js_key}=\"trigger('{trigger_name}')\""
@@ -544,12 +549,23 @@ def events(self, *names):
                             f"{js_key}=\"trigger('{trigger_name}')\""
                         )
                     if len(value) == 2:
+                        translated_value = (
+                            self.server.state.translator.translate_js_expression(
+                                self.server.state, value[1]
+                            )
+                        )
                         self._attributes[name] = (
-                            f"{js_key}=\"trigger('{trigger_name}', {value[1]})\""
+                            f"{js_key}=\"trigger('{trigger_name}', {translated_value})\""
                         )
                     if len(value) == 3:
+                        translated_value = (
+                            self.server.state.translator.translate_js_expression(
+                                self.server.state, value[1]
+                            )
+                        )
+                        # We don't want to translate kwargs as we may change keys rather than just values
                         self._attributes[name] = (
-                            f"{js_key}=\"trigger('{trigger_name}', {value[1]}, {value[2]})\""
+                            f"{js_key}=\"trigger('{trigger_name}', {translated_value}, {value[2]})\""
                         )
                 else:
                     print(