-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin adding windows support #314
base: master
Are you sure you want to change the base?
Conversation
# | ||
option(SMQTK_BUILD_EXAMPLES "Enable building examples." ON) | ||
option(SMQTK_INSTALL_SETUP_SCRIPT "Enable building examples." ON) | ||
mark_as_advanced(SMQTK_INSTALL_SETUP_SCRIPT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this defaulted to anything somewhere? Maybe we should just not install the setup script when we're on windows?
@@ -0,0 +1,3 @@ | |||
CMakeFiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be unnecessary due to the .gitignore
file two directories up?
Dev/libsvm windows
Looks like libsvm is build on windows now, but the dll is put in the source tree not install @hughed2 |
Minor fix, added a PR #341 |
Switch lib to dll for windows libsvm
No description provided.