Add check images script #292
Conversation
Also refactors compute_many_descriptors to use the newly generalized methods.
| PIL.Image.open(io.BytesIO(dfe.get_bytes())) | ||
| return True | ||
| except IOError, ex: | ||
| return False |
There was a problem hiding this comment.
Define a log = logging.getLogger(__name__) and reinstate the removed warning here.
| return False | ||
|
|
||
|
|
||
| def is_valid_element(fp, valid_content_types=None, check_image=False): |
There was a problem hiding this comment.
This should take in a DataElement input instead of a specific file path. This opens up the use of this function with things like URLs and stuff through other element implementations.
| from smqtk.representation.data_element.file_element import DataFileElement | ||
|
|
||
|
|
||
| def is_loadable_image(dfe): |
There was a problem hiding this comment.
This should move away from DataFileElement input requirement because nothing in the body of the function requires file-specific functionality. Should just take in a generic DataElement instance.
|
|
||
| :return: The data file element in the event of a valid element, or None if | ||
| it's invalid. | ||
| :rtype: DataFileElement | None |
There was a problem hiding this comment.
In isolation, I think it might make more sense if this function returned a boolean.
There was a problem hiding this comment.
I agree. I avoided it because compute_many_descriptors will have to be changed slightly.. but it's no big deal.
| :type dfe: DataFileElement | ||
|
|
||
| :return: Whether or not the image is loadable | ||
| :rtype bool: |
There was a problem hiding this comment.
typo. :rtype bool: -> :rtype: bool
danlamanna
force-pushed
the
add-check-images-script
branch
from
f52113a
to
40bef39
Compare
|
@Purg PTAL - My mock-fu isn't up to snuff, I would like to test that the logger is being called with the correct arguments, any suggestions? |
danlamanna
force-pushed
the
add-check-images-script
branch
from
d6133c8
to
5931c3d
Compare
danlamanna
force-pushed
the
add-check-images-script
branch
from
5931c3d
to
5291c9c
Compare
danlamanna
force-pushed
the
add-check-images-script
branch
from
4138aaa
to
00ea90d
Compare
|
Partially addresses #128 |
|
For mock testing, I'd say look at this for ideas. Also the mock documentation page of course. |
Fixes #286