Skip to content

Commit

Permalink
Merge pull request #156 from KingsburyLab/bugfix
Browse files Browse the repository at this point in the history
Hotfix v1.1.5 - remove stray assert statement
  • Loading branch information
rkingsbury authored Jul 29, 2024
2 parents 8c565ae + 65beb17 commit f1d3c6f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.1.5] - 2024-07-28

### Fixed

- `Solution`: Hotfix to remove a stray `assert` statement in `_adjust_charge_balance`
that would sometimes cause errors in`pH` charge balancing.

## [1.1.4] - 2024-07-28

### Fixed
Expand Down
1 change: 0 additions & 1 deletion src/pyEQL/solution.py
Original file line number Diff line number Diff line change
Expand Up @@ -2316,7 +2316,6 @@ def _adjust_charge_balance(self, atol=1e-8) -> None:
)
self.set_amount("H+", f"{new_hplus} mol/L")
self.set_amount("OH-", f"{K_W/new_hplus} mol/L")
assert np.isclose(self.charge_balance, 0, atol=atol), f"{self.charge_balance}"
return

z = self.get_property(self._cb_species, "charge")
Expand Down

0 comments on commit f1d3c6f

Please sign in to comment.