Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label select for k8s metadata processor #516

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

llhhbc
Copy link
Contributor

@llhhbc llhhbc commented May 13, 2023

Description

Add label selector for k8s metadata processor.
For only need watch some pod by label selector.
I'm not sure if I should limit which pods to fetch only in origin.

Related Issue

Motivation and Context

How Has This Been Tested?

@llhhbc llhhbc force-pushed the add-label-selector-for-k8s branch from 708cd65 to c87f868 Compare May 13, 2023 13:53
@dxsup
Copy link
Member

dxsup commented May 15, 2023

Could you please also provide an example of the configuration for selecting specified pods? It seems like you are using a set of "pod's labels" to match the "DataGroup's labels" which contain no k8s metadata when consumed by this processor.

@llhhbc
Copy link
Contributor Author

llhhbc commented May 15, 2023

I just ues the struct of kubernetes, It's configable. I will add some examples.

Signed-off-by: longhui.li <[email protected]>
@llhhbc
Copy link
Contributor Author

llhhbc commented May 16, 2023

@dxsup I have add some docs

@llhhbc
Copy link
Contributor Author

llhhbc commented Jul 26, 2023

@dxsup Can this be merged?

@dxsup
Copy link
Member

dxsup commented Jul 26, 2023

Sorry for the late reply. I guess the intention of this PR is to filter the DataGroups that match the labels given in the configuration file. A better implementation is we introduce a new processor which is designed to finish only this feature. How do you think? Could you spare time to finish this feature as a new processor?

@llhhbc
Copy link
Contributor Author

llhhbc commented Jul 31, 2023

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants