Skip to content

Commit

Permalink
SLES 12 SP5 fixes (Azure#658)
Browse files Browse the repository at this point in the history
* Fix conditional statement in install_workloadzone.sh

* Fix subscription_id assignment in providers.tf

* Fix indentation in deployment credential messages

* Fix deployment credential messages and subscription_id assignment

* chore: enable Azure scheduled events resource start and display output on SUSE

* Refactor deployment script to improve readability and remove unnecessary output

* Update provider version to 4.7

* Refactor tfvar_variables.tf to add a new variable for preventing deletion of resource groups with resources

* Add prevent_deletion_if_contains_resources variable to SystemModel.cs

* Refactor deployment script to improve readability and display deployment credentials

* Refactor deployment script to enable Stonith and concurrent fencing

* Refactor tfvar_variables.tf to add prevent_deletion_if_contains_resources variable

* Refactor validate.yml to remove single quotes from crm_resource output

* Refactor validate.yml to remove single quotes from crm_resource output

* fix ansible schema errors

* Refactor validate.yml to remove unnecessary 'when' condition

---------

Co-authored-by: Kimmo Forss <[email protected]>
Co-authored-by: hdamecharla <[email protected]>
  • Loading branch information
3 people committed Oct 31, 2024
1 parent bc72b2f commit 642801c
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 10 deletions.
4 changes: 2 additions & 2 deletions deploy/pipelines/02-sap-workload-zone.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ stages:
echo -e "$green---az login ---$reset"
echo -e "$cyan---Sourcing the deploy_server.sh file$reset"
. /etc/profile.d/deploy_server.sh ; /opt/bin/terraform/terraform --version
. /etc/profile.d/deploy_server.sh
if [ $USE_MSI != "true" ]; then
Expand Down Expand Up @@ -465,7 +465,7 @@ stages:
echo "Set Secrets returned: $secrets_set"
else
echo "Deployment credentials: Managed Identity"
echo "Deployment credentials: Managed Identity"
# export ARM_SUBSCRIPTION_ID=$ARM_SUBSCRIPTION_ID
export ARM_USE_MSI=true
export ARM_USE_AZUREAD=true
Expand Down
2 changes: 0 additions & 2 deletions deploy/pipelines/03-sap-system-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ stages:
. /etc/profile.d/deploy_server.sh
export ARM_SUBSCRIPTION_ID=$WL_ARM_SUBSCRIPTION_ID
if [ $USE_MSI != "true" ]; then
echo "Deployment credentials: Service Principal"
echo "Deployment credential ID (SPN): $WL_ARM_CLIENT_ID"
echo "Deployment credentials: Service Principal"
echo "Deployment credential ID (SPN): $WL_ARM_CLIENT_ID"
Expand Down
2 changes: 1 addition & 1 deletion deploy/terraform/run/sap_system/providers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ terraform {
}
azurerm = {
source = "hashicorp/azurerm"
version = "4.6.0"
version = "4.7.0"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
azurerm = {
source = "hashicorp/azurerm"
configuration_aliases = [azurerm.dnsmanagement, azurerm.main]
version = "4.6.0"
version = "4.7.0"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
azurerm = {
source = "hashicorp/azurerm"
configuration_aliases = [azurerm.main, azurerm.deployer, azurerm.dnsmanagement, azurerm.peering, azurerm.privatelinkdnsmanagement]
version = "4.6.0"
version = "4.7.0"
}

azapi = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
azurerm = {
source = "hashicorp/azurerm"
configuration_aliases = [azurerm.main, azurerm.deployer, azurerm.dnsmanagement, azurerm.privatelinkdnsmanagement]
version = "4.6.0"
version = "4.7.0"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
azurerm = {
source = "hashicorp/azurerm"
configuration_aliases = [azurerm.main, azurerm.deployer, azurerm.dnsmanagement, azurerm.privatelinkdnsmanagement] //
version = "4.6.0"
version = "4.7.0"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
azurerm = {
source = "hashicorp/azurerm"
configuration_aliases = [azurerm.main, azurerm.deployer, azurerm.dnsmanagement, azurerm.privatelinkdnsmanagement] //
version = "4.6.0"
version = "4.7.0"
}
}
}

0 comments on commit 642801c

Please sign in to comment.