Various improvements #42

hybridherbst · 2025-01-13T18:59:13Z

Mostly fixes – e.g.

registering existing nodes
fixing some caching issues
fixing some type issues

But also some changes:

switching default to Babylon engine
changing FPS of that to 60
some virtual pointers (not 100% confidence on some of them, e.g. the mesh ones)

… `mesh/{index}/primitive/{primIndex}/material`

…ding a file with flow/switch it's already an array

hybridherbst · 2025-01-13T19:00:10Z

I believe these changes are a strict improvement, so from our end I think it makes sense to merge it – let me know what you think!

src/BasicBehaveEngine/nodes/math/arithmetic/Mix.ts

src/BasicBehaveEngine/nodes/lifecycle/onTick.ts

src/BasicBehaveEngine/BasicBehaveEngine.ts

src/BasicBehaveEngine/BehaveEngineNode.ts

src/BasicBehaveEngine/decorators/BabylonDecorator.ts

src/authoring/AuthoringNodeSpecs.ts

mattmacf98

Looks really good thank you so much for these changes! I had a few small comments mostly on some duplicate authoring types and some small logic update reqeuests.

two things that stood out that I would like to leave out of this PR are the two things that are still being discussed in the spec (namely setting a primitive material and the initial out value for on tick when it is the first tick NaN vs 0)

… material

hybridherbst and others added 28 commits January 13, 2025 19:57

change default engine type to Babylon

08da120

feat: add button that can output a list of types used in this graph

4bbeef7

fixed NaN on first process in onTick timeSinceLastTick

a4b0564

added math/mix

01e9dcd

changes singleton onStart and onTick to multiple

ff2c140

optimized onTick with cached typeIndex

3d8546a

changed onTick time from ms to s

c1f3a90

renamed val to value in tests

3af0e55

added missing saturate node registry implementation

3693f5c

changed fps from 10 to 60

5b48ab5

fixed select event position

c417a7a

fixed warning let to const in bitwise nodes

1d0512e

added missing bitwise node registrations

772c536

fixed missing math/length registration

b29cd6f

added missing math/length registrations

6cd62ff

fix: register alertParentOnHoverIn and alertParentOnHoverOut

58218d3

fix wrong array access for matrices

9a24e9f

wip read-only access to nodes/{index}/mesh and read-write access to…

d8af196

… `mesh/{index}/primitive/{primIndex}/material`

wip

3c09627

fixed Mix node with float2, float3, float4 as C input

1e59f25

changed activeCamera.rotationQuaternion to activeCamera.absoluteRotation

a8f232e

fixed wrong quaternion components order in get/set rotation pointer

1125db0

fix: cconfiguration array parsing was assuming a string, but when loa…

b768f19

…ding a file with flow/switch it's already an array

fix: register math/fract

2d4c85a

register missing types

b4044aa

fix: cached values should also run through parseType

3724634

dev: log error when a single-entry array is encountered after evaluation

2a07680

set correct absRotation for active camera to xyzw

863bf0b

hybridherbst mentioned this pull request Jan 13, 2025

Behaviour when loading file is different to behaviour when re-running file #41

Closed