tests: Check if AS are supported for mutable #9362
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 361693. |
|
CI Vulkan-ValidationLayers build # 18947 running. |
|
CI Vulkan-ValidationLayers build # 18947 aborted. |
|
CI Vulkan-ValidationLayers build queued with queue ID 361903. |
|
CI Vulkan-ValidationLayers build # 18952 running. |
|
CI Vulkan-ValidationLayers build # 18952 passed. |
| @@ -572,6 +572,12 @@ TEST_F(PositiveDescriptors, CopyAccelerationStructureMutableDescriptors) { | |||
| create_info.bindingCount = bindings.size(); | |||
| create_info.pBindings = bindings.data(); | |||
|
|
|||
| VkDescriptorSetLayoutSupport dsl_support = vku::InitStructHelper(); | |||
| vk::GetDescriptorSetLayoutSupport(device(), &create_info, &dsl_support); | |||
| if (!dsl_support.supported) { | |||
There was a problem hiding this comment.
missed opportunity to blame the driver in the comment?
There was a problem hiding this comment.
no, VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR is an optional type for Mutable Descriptors, we (as a bad test) did not check
#7609 would have caught it, but need to get that PR up again
artem-lunarg
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RADV doesn't support
VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHRforVK_DESCRIPTOR_TYPE_MUTABLE_EXTand needs to be checked