Validate 2d image blit with invalid z offsets #9357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 361099. |
|
CI Vulkan-ValidationLayers build # 18933 running. |
ziga-lunarg
force-pushed
the
ziga-issue-9354
branch
from
442afa9 to
30dab9c
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 361131. |
|
CI Vulkan-ValidationLayers build # 18935 running. |
|
CI Vulkan-ValidationLayers build # 18935 passed. |
ziga-lunarg
force-pushed
the
ziga-issue-9354
branch
from
30dab9c to
c63b751
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 361176. |
|
CI Vulkan-ValidationLayers build # 18937 running. |
|
CI Vulkan-ValidationLayers build # 18937 passed. |
| @@ -3377,6 +3377,9 @@ bool CoreChecks::ValidateCmdBlitImage(VkCommandBuffer commandBuffer, VkImage src | |||
| ") but srcImage is VK_IMAGE_TYPE_3D", | |||
| src_subresource.baseArrayLayer, src_subresource.layerCount, dst_subresource.layerCount); | |||
| } | |||
| } else if (static_cast<uint32_t>(abs(region.dstOffsets[0].z - region.dstOffsets[1].z)) != src_subresource.layerCount) { | |||
| vuid = is_2 ? "VUID-VkBlitImageInfo2-maintenance8-10579" : "VUID-vkCmdBlitImage-maintenance8-10579"; | |||
| skip |= LogError(vuid, all_objlist, region_loc.dot(Field::dstOffsets), "fail"); | |||
There was a problem hiding this comment.
better error messages 🙏
ziga-lunarg
force-pushed
the
ziga-issue-9354
branch
from
c63b751 to
19df63f
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 361301. |
|
CI Vulkan-ValidationLayers build # 18942 running. |
|
CI Vulkan-ValidationLayers build # 18942 passed. |
spencer-lunarg
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9354
I don't see a way to get one without the other