gpuav: Improve shader map management #9307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 355210. |
|
CI Vulkan-ValidationLayers build # 18851 running. |
jeremyg-lunarg
approved these changes
Jan 24, 2025
| @@ -52,6 +52,7 @@ struct ShaderObject : public StateObject { | |||
| // TOOD Create a shader object inherited class | |||
| struct InstrumentationData { | |||
| bool was_instrumented = false; | |||
| uint32_t unique_shader_id = 0xffff'ffff; | |||
There was a problem hiding this comment.
unique_shader_id of 0 is used in IsInstrumented to mean "not valid"
so just use 0, it is already defined as the "invalid" value
| @@ -138,7 +138,7 @@ class Pipeline : public StateObject { | |||
| // ment for GPU-AV | |||
| struct InstrumentationData { | |||
| // We create a VkShaderModule that is instrumented and need to delete before leaving the pipeline call | |||
| std::vector<VkShaderModule> instrumented_shader_module; | |||
| std::vector<std::pair<uint32_t, VkShaderModule>> instrumented_shader_modules; | |||
There was a problem hiding this comment.
comment what this pair is
| if (auto pipeline_state = Get<vvl::Pipeline>(pipeline)) { | ||
| for (auto shader_module : pipeline_state->instrumentation_data.instrumented_shader_module) { | ||
| DispatchDestroyShaderModule(device, shader_module, pAllocator); | ||
| for (auto shader_module : pipeline_state->instrumentation_data.instrumented_shader_modules) { |
There was a problem hiding this comment.
can we do the auto [unique_shader_id, shader_module_handle] syntax because it is a std::pair?
spencer-lunarg
approved these changes
Jan 24, 2025
|
CI Vulkan-ValidationLayers build # 18851 passed. |
Deleting an element from instrumented_shaders_map_ was too slow
arno-lunarg
force-pushed
the
arno-gpuav-instrumentated-shaders-map-updates-rework
branch
from
dead474 to
3c0e7d6
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 355292. |
|
CI Vulkan-ValidationLayers build # 18853 running. |
|
CI Vulkan-ValidationLayers build # 18853 passed. |
arno-lunarg
deleted the
arno-gpuav-instrumentated-shaders-map-updates-rework
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting an element from instrumented_shaders_map_ was too slow