stateless: Remove ValidatePnextPropertyStructContents() #9302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 354356. |
|
CI Vulkan-ValidationLayers build # 18839 running. |
jeremyg-lunarg
force-pushed
the
jeremyg-properties-pnext
branch
from
5c1996c to
7be0b5c
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 354372. |
|
CI Vulkan-ValidationLayers build # 18840 running. |
| @@ -442,6 +442,9 @@ def generateSource(self): | |||
| property_structs = [x for x in extended_structs if x.extends == ["VkPhysicalDeviceProperties2"]] | |||
| other_structs = [x for x in extended_structs if x not in feature_structs and x not in property_structs and x.name not in self.structsWithManualChecks] | |||
|
|
|||
| # NOTE: property structs are no longer checked. Previously we only checked if the corresponding extension was supported | |||
There was a problem hiding this comment.
maybe worth putting this above property_structs declaration and point to link to #9302 for future reference
spencer-lunarg
approved these changes
Jan 23, 2025
Property pNext checking was implemented incorrectly for a long time and recently fixed by commit da1b588. However requiring extensions enabled for querying properties is very cumbersome and contradicts this statement from the specification: Any component of the implementation (the loader, any enabled layers, and drivers) must skip over, without processing (other than reading the sType and pNext members) any extending structures in the chain not defined by core versions or extensions supported by that component. It is possible that this could also be relaxed for other queries in the future.
VUID-VkPhysicalDeviceProperties2-pNext-pNext will no longer fire if a property structure is included without its extension being enabled.
jeremyg-lunarg
force-pushed
the
jeremyg-properties-pnext
branch
from
7be0b5c to
233df20
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 354408. |
|
CI Vulkan-ValidationLayers build # 18841 running. |
|
CI Vulkan-ValidationLayers build # 18841 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 354445. |
|
CI Vulkan-ValidationLayers build # 18842 running. |
|
CI Vulkan-ValidationLayers build # 18842 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property pNext checking was implemented incorrectly for a long time and recently fixed by commit da1b588. However requiring extensions enabled for querying properties is very cumbersome and contradicts this statement from the specification:
It is possible that this could also be relaxed for other queries in the future.