sync: Replace SyncOp factories with regular functions #9301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code templated with factory class was hard read because of general naming (e.g. MakeApplyFunctor) that was used to unite different implementations. Also missing symbol navigation.
|
CI Vulkan-ValidationLayers build queued with queue ID 354169. |
|
CI Vulkan-ValidationLayers build # 18838 running. |
|
CI Vulkan-ValidationLayers build # 18838 passed. |
spencer-lunarg
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was historically a bit hard to follow because of generic naming in factory classes (e.g.
MakeApplyFunctor). Also editor navigation did not work because of templated types.