-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
printf: Don't do work when there is no printf instruction #9256
printf: Don't do work when there is no printf instruction #9256
Conversation
CI Vulkan-ValidationLayers build queued with queue ID 349236. |
CI Vulkan-ValidationLayers build # 18755 running. |
CI Vulkan-ValidationLayers build # 18755 failed. |
CI Vulkan-ValidationLayers build queued with queue ID 349488. |
CI Vulkan-ValidationLayers build queued with queue ID 349517. |
CI Vulkan-ValidationLayers build # 18761 running. |
CI Vulkan-ValidationLayers build # 18761 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is convoluted, a lot changes in different spots to simply express "don't try to setup instrumentation validation resources when bound pipeline has not been instrumented".
It shows that we still have problems with the architecture : /
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just go if (!last_bound.pipeline_state.instrumentation_data.was_instrumented) return;
in <Pre, Post>CallSetupShaderInstrumentationResources
?
Honestly I don't know what to change?
So we have 2 spots (between 1-and-2 and 2-and-3) to hold this state, not sure how else to get around it |
2ad9098
to
4c5844b
Compare
Found using
VK_LAYER_PRINTF_ONLY_PRESET
slows down things way too much by default. With this change, find that when an app uses no printf in their shader (because assuming only 1 of there many pipelines will even have it) you regain near "normal" FPS againnote -
VK_LAYER_PRINTF_ONLY_PRESET
turns off everything but DebugPrintf just like vkconfig does