Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layers: Combine vkCmdSetDiscardRectangleEXT check #9210

Merged
merged 1 commit into from
Jan 15, 2025
Merged

layers: Combine vkCmdSetDiscardRectangleEXT check #9210

merged 1 commit into from
Jan 15, 2025

Conversation

spencer-lunarg
Copy link
Contributor

For change in https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/7099

New VU error looks like

[ VUID-vkCmdDraw-None-07751 ] vkCmdDraw(): vkCmdSetDiscardRectangleEXT was not set for discard rectangle index 1 for this command buffer. Need to set once for each in discardRectangleCount (2). (There was a call to vkCmdBindPipeline that didn't have VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT and invalidated the prior vkCmdSetDiscardRectangleEXT call).

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner January 13, 2025 16:08
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 343775.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18628 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18628 passed.

@spencer-lunarg spencer-lunarg force-pushed the spencer-lunarg-ds-discard-rect branch from 691d626 to f00e6d9 Compare January 13, 2025 18:50
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 344006.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18632 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18632 passed.

@spencer-lunarg spencer-lunarg force-pushed the spencer-lunarg-ds-discard-rect branch from f00e6d9 to 0efd597 Compare January 15, 2025 16:55
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 346042.

@spencer-lunarg spencer-lunarg force-pushed the spencer-lunarg-ds-discard-rect branch from 0efd597 to 99c51bf Compare January 15, 2025 16:58
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 346057.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18680 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18680 passed.

@spencer-lunarg spencer-lunarg merged commit 47b293d into KhronosGroup:main Jan 15, 2025
21 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-ds-discard-rect branch January 15, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziga-lunarg ziga-lunarg ziga-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencer-lunarg @ci-tester-lunarg @ziga-lunarg