layers: Include values in wsi logs #9208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 343563. |
|
CI Vulkan-ValidationLayers build # 18623 running. |
|
CI Vulkan-ValidationLayers build # 18623 failed. |
spencer-lunarg
approved these changes
Jan 13, 2025
tests/unit/wsi.cpp
Outdated
| swapchain_ci.clipped = VK_FALSE; | ||
| swapchain_ci.oldSwapchain = 0; | ||
|
|
||
| m_errorMonitor->SetAllowedFailureMsg("VUID-VkSwapchainCreateInfoKHR-compositeAlpha-01280"); |
There was a problem hiding this comment.
so this is failing on AMD Windows, should this not be SetDesiredError because by having it SetAllowedFailureMsg it will still try to create the VkSwapchian which in this case is invalid and blowing up CI machine
There was a problem hiding this comment.
Wrong copy paste!
ziga-lunarg
force-pushed
the
ziga-improve-wsi-log-msg
branch
from
7385242 to
01d7edb
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 343622. |
|
CI Vulkan-ValidationLayers build # 18625 running. |
|
CI Vulkan-ValidationLayers build # 18625 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.