Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layers: Use correct VUID for signaling signaled semaphore #9205

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

artem-lunarg
Copy link
Contributor

Closes #9191

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 342485.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18613 running.

@artem-lunarg artem-lunarg marked this pull request as ready for review January 10, 2025 20:22
@artem-lunarg artem-lunarg requested a review from a team as a code owner January 10, 2025 20:22
skip |= core.LogError(
"VUID-vkQueueSubmit-pCommandBuffers-00065", objlist, signal_semaphore_loc,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we now missing validation for 00065?

Copy link
Contributor Author

@artem-lunarg artem-lunarg Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. From what I remember from the last year the events in core checks have implementation issues. I used BP as playground to implement "proper" event tracking here #8033 (in addition to command primary buffer tracking, track secondary cmdbufs and state between submissions), and the idea was later to do similar thing in core checks (that implementation was almost the same code that core checks needs). This also includes moving parts of code from syncval (for some reason part of even code are there...). If you notice something fix is limited by current implementation it's probably can be postponed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18613 passed.

@artem-lunarg artem-lunarg merged commit b77227b into KhronosGroup:main Jan 10, 2025
21 checks passed
@artem-lunarg artem-lunarg deleted the artem-fix-vuid branch January 10, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VUID-vkQueueSubmit-pCommandBuffers-00065 is validating the wrong thing
3 participants