gpu: Remove passthrough to run a Pass

[spencer-lunarg]

We use to add this

bool Module::RunPassDescriptorIndexingOOB() {
    DescriptorIndexingOOBPass pass(*this);
    const bool changed = pass.Run();
    if (print_debug_info_) {
        pass.PrintDebugInfo();
    }
    return changed;
}

type logic for every pass we added, removed it (and just passed in enabled_features) so it is more streamline to quickly/easily add a new SPIR-V pass

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build queued with queue ID 342384.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build queued with queue ID 342399.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build # 18609 running.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build # 18609 passed.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build queued with queue ID 342649.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build # 18615 running.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build # 18615 passed.

[arno-lunarg]

should support_non_semantic_info_ be removed too?

[spencer-lunarg]

this is from an extension, was debating to do it, but doubt other passes care about extension, but 100% will care about feature bits

[arno-lunarg]

a Start calls for a End or a Finish, so IMO inappropriate here.
If I follow things correctly, Run is now only called within Start.
So I would expect calls now looking like modified |= texel_buffer_pass.Start(); to stay similar to how they were, by going modified |= texel_buffer_pass.Run();
And here Run would look like your Start:

bool Pass::Run() {
    // I too would like to have "Instrument" be called `Run`, but since we can't I guess we can only cope 
    // Also "Instrument" should probably be a `protected` method
    const bool modified = Instrument();
    if (module_.print_debug_info_) {
        PrintDebugInfo();
    }
    return modified;
}

[spencer-lunarg]

the Run() is what spirv-opt uses to "run a pass"

honestly Run and Instrument are better... I just picked Start because I needed a name

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build queued with queue ID 344603.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build # 18645 running.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build # 18645 failed.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build queued with queue ID 344715.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build # 18649 running.

[ci-tester-lunarg]

CI Vulkan-ValidationLayers build # 18649 passed.