Fix robustBufferAccess2 check for 08798 #9184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 341092. |
|
CI Vulkan-ValidationLayers build # 18584 running. |
|
CI Vulkan-ValidationLayers build # 18584 passed. |
| return; | ||
| } | ||
|
|
||
| const LvlBindPoint lv_bind_point = ConvertToLvlBindPoint(VK_PIPELINE_BIND_POINT_GRAPHICS); |
There was a problem hiding this comment.
The idea is we don't need to go doing a state object lookup for most people, so this should look like
if (gpuav.enabled_features.robustBufferAccess2) {
return;
}
if (gpuav.enabled_features.pipelineRobustness) {
const LvlBindPoint lv_bind_point = ConvertToLvlBindPoint(VK_PIPELINE_BIND_POINT_GRAPHICS);
const LastBound &last_bound = cb_state.lastBound[lv_bind_point];
const vvl::Pipeline *pipeline_state = last_bound.pipeline_state;
if (pipeline_state) {
const auto robustness_ci =
vku::FindStructInPNextChain<VkPipelineRobustnessCreateInfo>(pipeline_state->GraphicsCreateInfo().pNext);
if (robustness_ci && robustness_ci->vertexInputs) {
return;
}
}
}
ziga-lunarg
force-pushed
the
ziga-fix-08798
branch
from
b07b706 to
5e4969b
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 341154. |
|
CI Vulkan-ValidationLayers build # 18585 running. |
|
CI Vulkan-ValidationLayers build # 18585 passed. |
spencer-lunarg
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.