Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bp: Fix signaling events #9169

Merged
merged 2 commits into from
Jan 8, 2025
Merged

bp: Fix signaling events #9169

merged 2 commits into from
Jan 8, 2025

Conversation

ziga-lunarg
Copy link
Contributor

No description provided.

@ziga-lunarg ziga-lunarg requested a review from a team as a code owner January 8, 2025 15:29
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 340252.

spencer-lunarg
spencer-lunarg reviewed Jan 8, 2025
View reviewed changes
tests/unit/best_practices_positive.cpp Outdated
TEST_F(VkPositiveBestPracticesLayerTest, ResetCommandPool) {
TEST_DESCRIPTION("Test creating fifo relaxed swapchain");

AddSurfaceExtension();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this needed?

artem-lunarg
artem-lunarg reviewed Jan 8, 2025
View reviewed changes
layers/best_practices/bp_instance_device.cpp
@@ -348,7 +348,9 @@ struct EventValidator {
} else {
// check global event state
auto event_state = state_tracker.Get<vvl::Event>(event);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it's null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the event has been destroyed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I assume on destruction the objects are removed form state tracker, did I miss something? @jeremyg-lunarg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bp, and there is no remove from event_signaling_state anywhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks. If you don't see an issue with this I'll create issue to manage lifetime of objects in event_signaling_state. It was added in #8033 but not sure why not lifetime management.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18566 running.

spencer-lunarg
spencer-lunarg reviewed Jan 8, 2025
View reviewed changes
tests/unit/best_practices_positive.cpp Outdated
@@ -423,3 +423,27 @@ TEST_F(VkPositiveBestPracticesLayerTest, CreateFifoRelaxedSwapchain) {
m_errorMonitor->SetAllowedFailureMsg("VUID-VkSwapchainCreateInfoKHR-presentMode-02839");
m_swapchain.Init(*m_device, swapchain_create_info);
}

TEST_F(VkPositiveBestPracticesLayerTest, ResetCommandPool) {
TEST_DESCRIPTION("Test creating fifo relaxed swapchain");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reword or remove

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 340269.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 340284.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18568 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18568 failed.

@artem-lunarg artem-lunarg mentioned this pull request Jan 8, 2025
Open
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 340354.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18569 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18569 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 340396.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18571 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 340415.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18572 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 340439.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18573 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18573 passed.

@spencer-lunarg spencer-lunarg merged commit 196627c into KhronosGroup:main Jan 8, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-lunarg spencer-lunarg spencer-lunarg approved these changes

@artem-lunarg artem-lunarg artem-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ziga-lunarg @ci-tester-lunarg @spencer-lunarg @artem-lunarg