Add missing wsi tests #9159
Add missing wsi tests #9159
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 339181. |
layers/core_checks/cc_wsi.cpp
Outdated
| @@ -1017,7 +1017,9 @@ bool CoreChecks::PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentIn | |||
| for (uint32_t i = 0; i < swapchain_present_mode_info->swapchainCount; i++) { | |||
| const VkPresentModeKHR present_mode = swapchain_present_mode_info->pPresentModes[i]; | |||
| const auto swapchain_state = Get<vvl::Swapchain>(pPresentInfo->pSwapchains[i]); | |||
| ASSERT_AND_CONTINUE(swapchain_state); | |||
| if (!swapchain_state) { | |||
There was a problem hiding this comment.
This would be hit by NegativeWsi.PresentMismatchedSwapchainCount
|
CI Vulkan-ValidationLayers build # 18553 running. |
ziga-lunarg
force-pushed
the
ziga-issue-9151
branch
from
40e159a to
5b93994
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 339197. |
|
CI Vulkan-ValidationLayers build # 18554 running. |
layers/core_checks/cc_wsi.cpp
Outdated
| @@ -930,7 +930,7 @@ bool CoreChecks::PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentIn | |||
| string_VkSurfaceTransformFlagBitsKHR(swapchain_data->create_info.preTransform), | |||
| swapchain_data->create_info.imageExtent.height); | |||
| } | |||
| if (rect.layer > swapchain_data->create_info.imageArrayLayers) { | |||
| if (rect.layer >= swapchain_data->create_info.imageArrayLayers) { | |||
There was a problem hiding this comment.
... why so glad we are getting these tests added
|
CI Vulkan-ValidationLayers build # 18554 failed. |
ziga-lunarg
force-pushed
the
ziga-issue-9151
branch
from
5b93994 to
e6cd234
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 341215. |
|
CI Vulkan-ValidationLayers build # 18586 running. |
|
CI Vulkan-ValidationLayers build # 18586 failed. |
ziga-lunarg
force-pushed
the
ziga-issue-9151
branch
from
e6cd234 to
5bc3cb0
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 341267. |
|
CI Vulkan-ValidationLayers build # 18588 running. |
|
CI Vulkan-ValidationLayers build # 18588 failed. |
|
@ziga-lunarg can you rebase, I will have time this week to triage any failing internal CI issues |
ziga-lunarg
force-pushed
the
ziga-issue-9151
branch
from
5bc3cb0 to
3efdf13
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 343513. |
|
CI Vulkan-ValidationLayers build # 18620 running. |
|
CI Vulkan-ValidationLayers build # 18620 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 343606. |
|
CI Vulkan-ValidationLayers build # 18624 running. |
|
CI Vulkan-ValidationLayers build # 18624 passed. |
|
@ziga-lunarg - my little dirty secret, I sometimes just put my new tests somewhere random inside the test file (usually find another similar test) and it prevents these merge conflicts 😆 |
ziga-lunarg
force-pushed
the
ziga-issue-9151
branch
from
3efdf13 to
f15f577
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 343738. |
|
CI Vulkan-ValidationLayers build # 18627 running. |
|
CI Vulkan-ValidationLayers build # 18627 passed. |
No description provided.