Add missing swapchain maintenance validation #9107
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 333769. |
|
CI Vulkan-ValidationLayers build # 18467 running. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
772e5c7 to
e26b410
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 333786. |
|
CI Vulkan-ValidationLayers build # 18468 running. |
|
CI Vulkan-ValidationLayers build # 18468 failed. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
e26b410 to
a55ca57
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 336756. |
|
CI Vulkan-ValidationLayers build # 18499 running. |
|
CI Vulkan-ValidationLayers build # 18499 failed. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
a55ca57 to
db2e303
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 336815. |
|
CI Vulkan-ValidationLayers build # 18502 running. |
|
CI Vulkan-ValidationLayers build # 18502 failed. |
|
@ziga-lunarg rebase and I will look into CI failures (don't want these to go stale) |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
db2e303 to
6af1fdc
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 343529. |
|
CI Vulkan-ValidationLayers build # 18621 running. |
|
CI Vulkan-ValidationLayers build # 18621 failed. |
| @@ -1875,6 +1875,7 @@ TEST_F(NegativeWsi, SwapchainMaintenance1ExtensionAcquire) { | |||
| AddRequiredExtensions(VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME); | |||
| AddRequiredExtensions(VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME); | |||
| AddSurfaceExtension(); | |||
| AddRequiredFeature(vkt::Feature::swapchainMaintenance1); | |||
There was a problem hiding this comment.
this is needed for PositiveWsi.CreateSwapchainWithPresentModeInfo and PositiveWsi.PresentFenceWaitsForSubmission
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
6af1fdc to
a1cf254
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 343638. |
|
CI Vulkan-ValidationLayers build # 18626 running. |
|
CI Vulkan-ValidationLayers build # 18626 aborted. |
| @@ -1351,6 +1352,7 @@ TEST_F(PositiveWsi, PresentFenceWaitsForSubmission) { | |||
| AddSurfaceExtension(); | |||
| AddRequiredExtensions(VK_EXT_SURFACE_MAINTENANCE_1_EXTENSION_NAME); | |||
| AddRequiredExtensions(VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME); | |||
| AddRequiredFeature(vkt::Feature::swapchainMaintenance1); | |||
There was a problem hiding this comment.
PresentFenceRetiresPresentQueueOperation also needs this
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
a1cf254 to
2fc93e4
Compare
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
2fc93e4 to
980108b
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 346809. |
|
CI Vulkan-ValidationLayers build # 18690 running. |
|
CI Vulkan-ValidationLayers build # 18690 failed. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
980108b to
63aea15
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 346852. |
|
CI Vulkan-ValidationLayers build # 18691 running. |
|
CI Vulkan-ValidationLayers build # 18691 failed. |
ziga-lunarg
force-pushed
the
ziga-issue-9099
branch
from
63aea15 to
5d0a4de
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 346925. |
|
CI Vulkan-ValidationLayers build # 18692 running. |
|
CI Vulkan-ValidationLayers build # 18692 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 347008. |
|
CI Vulkan-ValidationLayers build # 18696 running. |
|
CI Vulkan-ValidationLayers build # 18696 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 347072. |
|
CI Vulkan-ValidationLayers build # 18697 running. |
|
CI Vulkan-ValidationLayers build # 18697 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 347357. |
|
CI Vulkan-ValidationLayers build # 18703 running. |
|
CI Vulkan-ValidationLayers build # 18703 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 348173. |
|
CI Vulkan-ValidationLayers build # 18731 running. |
|
CI Vulkan-ValidationLayers build # 18731 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 348472. |
|
CI Vulkan-ValidationLayers build # 18734 running. |
|
CI Vulkan-ValidationLayers build # 18734 passed. |
NEED TO HURRY NOW! |
Closes #9099