Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpuav: Rename gpu folder to gpuav #8995

Merged
merged 1 commit into from
Jan 11, 2025
Merged

gpuav: Rename gpu folder to gpuav #8995

merged 1 commit into from
Jan 11, 2025

Conversation

arno-lunarg
Copy link
Contributor

@arno-lunarg arno-lunarg commented Dec 10, 2024 •
edited
Loading

Also rename cmd_validation to validation_cmd, a name that actually describes one of GPU-AV's feature: inserting validation commands. "Command validation" is a name encompassing every GPU-AV feature, thus a bad choice to label a particular GPU-AV feature

@arno-lunarg arno-lunarg requested a review from a team as a code owner December 10, 2024 09:37
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 320733.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18268 running.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-rename-gpu-folder branch from 8e69703 to 621e343 Compare December 10, 2024 09:42
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 320749.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18269 running.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-rename-gpu-folder branch from 621e343 to 80e99ff Compare December 10, 2024 09:46
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 320765.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18270 running.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-rename-gpu-folder branch from 80e99ff to ef54b4a Compare December 10, 2024 09:51
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 320781.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18271 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18271 passed.

spencer-lunarg
spencer-lunarg requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@spencer-lunarg spencer-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the validation_cmd to cmd_validation change, but there is an upcoming extension that will be released soon that has GPU-AV being worked on and they have spent a lot of effort and really don't want them to rebase on this "for sake of rebasing" ... happy to do it after that

@arno-lunarg
Copy link
Contributor Author

I am happy with the validation_cmd to cmd_validation change, but there is an upcoming extension that will be released soon that has GPU-AV being worked on and they have spent a lot of effort and really don't want them to rebase on this "for sake of rebasing" ... happy to do it after that

ok!

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-rename-gpu-folder branch from ef54b4a to f7940ec Compare January 9, 2025 10:16
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 341022.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18583 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18583 aborted.

@arno-lunarg arno-lunarg force-pushed the arno-gpuav-rename-gpu-folder branch from f7940ec to c9ab41e Compare January 10, 2025 07:35
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 341956.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18596 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18596 failed.

@arno-lunarg
gpuav: Rename gpu folder to gpuav
2def036 
Also rename `cmd_validation` to `validation_cmd`, a name that
actually describes one of GPU-AV's feature:
inserting validation commands
@arno-lunarg arno-lunarg force-pushed the arno-gpuav-rename-gpu-folder branch from c9ab41e to 2def036 Compare January 10, 2025 23:07
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 342562.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18614 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18614 passed.

@spencer-lunarg spencer-lunarg merged commit 10f90cc into KhronosGroup:main Jan 11, 2025
21 checks passed
@arno-lunarg arno-lunarg deleted the arno-gpuav-rename-gpu-folder branch January 11, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-lunarg spencer-lunarg spencer-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arno-lunarg @ci-tester-lunarg @spencer-lunarg