Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌴sync: Ensure handle index is valid #8317

Merged
merged 2 commits into from
Jul 24, 2024
Merged

🌴sync: Ensure handle index is valid #8317

merged 2 commits into from
Jul 24, 2024

Conversation

artem-lunarg
Copy link
Contributor

@artem-lunarg artem-lunarg commented Jul 24, 2024 •
edited
Loading

#8291 discovered two problems:

  1. There is a potential syncval bug. Will be fixed in another PR, we have a deterministic repro case.
  2. If syncval resource reporting invariants get invalidated this leads to crash/assert. The above syncval bug leads to such bad state and it will be fixed. But the same happens when we have unhandled core validation error (when core validation is disabled). The convention that syncval should handle this gracefully without crashing, although does not guarantee that reporting is correct.

This PR addresses problem 2.

@artem-lunarg
sync: Ensure handle index is valid
4e1e5f9 
Can be invalid due to unhandled core validation error
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 223313.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17112 running.

@artem-lunarg artem-lunarg force-pushed the artem-sync-handle-index branch from d96ed97 to e30040f Compare July 24, 2024 16:41
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 223337.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17114 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17114 passed.

@artem-lunarg artem-lunarg marked this pull request as ready for review July 24, 2024 17:06
@artem-lunarg artem-lunarg requested a review from a team as a code owner July 24, 2024 17:06
spencer-lunarg
spencer-lunarg approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@spencer-lunarg spencer-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best PTO code I have ever seen

@artem-lunarg artem-lunarg changed the title sync: Ensure handle index is valid 🌴sync: Ensure handle index is valid Jul 24, 2024
@artem-lunarg artem-lunarg merged commit b88a3ee into KhronosGroup:main Jul 24, 2024
21 checks passed
@artem-lunarg artem-lunarg deleted the artem-sync-handle-index branch July 24, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-lunarg spencer-lunarg spencer-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem-lunarg @ci-tester-lunarg @spencer-lunarg