Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add and link error codes for extensions #1119

Merged
merged 12 commits into from
Apr 2, 2024

Conversation

bashbaug
Copy link
Contributor

Fixes #1095

Adds error codes for all extensions to the table in appendix F.

@bashbaug bashbaug requested a review from alycm March 31, 2024 20:21
@oddhack
Copy link
Contributor

oddhack commented Mar 31, 2024

LGTM. I'm in favor of having literally every API / header macro described in the API spec, but didn't want to be intrusive about that when doing the extension integration. This is great progress. I think there are still structures and macros in the XML that are not described in the spec.

@oddhack oddhack mentioned this pull request Apr 1, 2024
Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

api/appendix_f.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Alastair Murray <[email protected]>
@bashbaug bashbaug merged commit 93f7aaa into KhronosGroup:main Apr 2, 2024
2 checks passed
@bashbaug bashbaug deleted the add-and-link-error-codes branch April 2, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent error codes in Appendix F
3 participants