Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Icon a11y docs to specify 3:1 contrast ratio #2133

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Dec 2, 2023

Summary:

Turns out that icons can have a 3:1 contrast ratio, and
the article I initially used to say 4.5:1 misinterpreted
the spec. Thanks to Sarah B for pointing this out!

More info:
https://khanacademy.slack.com/archives/C8Z9DSKC7/p1700588780588889

Issue: non

Test plan:

@nishasy nishasy self-assigned this Dec 2, 2023
Copy link

changeset-bot bot commented Dec 2, 2023

🦋 Changeset detected

Latest commit: 608ed82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nishasy nishasy requested a review from jandrade December 2, 2023 00:27
@nishasy nishasy marked this pull request as ready for review December 2, 2023 00:27
@khan-actions-bot khan-actions-bot requested a review from a team December 2, 2023 00:27
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to .changeset/slow-pigs-sip.md, __docs__/wonder-blocks-icon/accessibility.stories.mdx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Dec 2, 2023

Size Change: 0 B

Total Size: 90.9 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 3.69 kB
packages/wonder-blocks-banner/dist/es/index.js 1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.72 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 4.27 kB
packages/wonder-blocks-cell/dist/es/index.js 2.19 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.24 kB
packages/wonder-blocks-color/dist/es/index.js 1.15 kB
packages/wonder-blocks-core/dist/es/index.js 3.67 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-dropdown/dist/es/index.js 12 kB
packages/wonder-blocks-form/dist/es/index.js 5.34 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.54 kB
packages/wonder-blocks-icon-button/dist/es/index.js 3.21 kB
packages/wonder-blocks-icon/dist/es/index.js 1.06 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.88 kB
packages/wonder-blocks-link/dist/es/index.js 2.54 kB
packages/wonder-blocks-modal/dist/es/index.js 5.04 kB
packages/wonder-blocks-pill/dist/es/index.js 1.03 kB
packages/wonder-blocks-popover/dist/es/index.js 4.33 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.55 kB
packages/wonder-blocks-spacing/dist/es/index.js 158 B
packages/wonder-blocks-switch/dist/es/index.js 2.06 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 1.21 kB
packages/wonder-blocks-timing/dist/es/index.js 1.78 kB
packages/wonder-blocks-toolbar/dist/es/index.js 862 B
packages/wonder-blocks-tooltip/dist/es/index.js 5.05 kB
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Merging #2133 (608ed82) into main (9092363) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2133   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files         241      241           
  Lines       28038    28038           
  Branches     2464     2381   -83     
=======================================
  Hits        27212    27212           
  Misses        826      826           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9092363...608ed82. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 2, 2023

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-cqgvqeagee.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 0
Tests with visual changes 0
Total stories 388
Inherited (not captured) snapshots [TurboSnap] 316
Tests on the build 316

Copy link
Contributor

github-actions bot commented Dec 2, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (28d0413) and published all packages with changesets to npm.

You can install the packages in webapp by running:

./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2133"

Packages can also be installed manually by running:

yarn add @khanacademy/wonder-blocks-<package-name>@PR2133

Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, thank you!

@nishasy nishasy merged commit 071f130 into main Dec 5, 2023
21 checks passed
@nishasy nishasy deleted the update-icon-a11y-docs branch December 5, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants