-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Icon a11y docs to specify 3:1 contrast ratio #2133
Conversation
🦋 Changeset detectedLatest commit: 608ed82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 90.9 kB ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2133 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 241 241
Lines 28038 28038
Branches 2464 2381 -83
=======================================
Hits 27212 27212
Misses 826 826 Continue to review full report in Codecov by Sentry.
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-cqgvqeagee.chromatic.com/ Chromatic results:
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (28d0413) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2133" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah great, thank you!
Summary:
Turns out that icons can have a 3:1 contrast ratio, and
the article I initially used to say 4.5:1 misinterpreted
the spec. Thanks to Sarah B for pointing this out!
More info:
https://khanacademy.slack.com/archives/C8Z9DSKC7/p1700588780588889
Issue: non
Test plan:
article.